Skip to content

[Docs] Add a security guide #17230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2025
Merged

[Docs] Add a security guide #17230

merged 5 commits into from
Apr 28, 2025

Conversation

@russellb
Copy link
Member

@russellb russellb commented Apr 26, 2025

Start a security guide in the project docs. The primary topic covered is
the importance of securing the network used for communications between
vLLM nodes.

Signed-off-by: Russell Bryant rbryant@redhat.com

@github-actions
Copy link

github-actions bot commented Apr 26, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 26, 2025
mgoin
mgoin reviewed Apr 26, 2025
View reviewed changes
russellb added 3 commits April 28, 2025 10:02
@russellb
[Docs] Add a security guide
d370d8a 
Start a security guide in the project docs. The primary topic covered is
the importance of securing the network used for communications between
vLLM nodes.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
@russellb
Add a link to security reporting policy in the security guide
c7e2046 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
@russellb
Move doc to deployment section
d0d35d7 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
DarkLight1337
DarkLight1337 reviewed Apr 28, 2025
View reviewed changes
DarkLight1337
DarkLight1337 reviewed Apr 28, 2025
View reviewed changes
russellb and others added 2 commits April 28, 2025 10:28
@russellb @DarkLight1337
Update docs/source/deployment/security.md
eb78a4a 
Signed-off-by: Russell Bryant <rbryant@redhat.com>

Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
@russellb
Update docs/source/deployment/security.md
b92458d 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
DarkLight1337
DarkLight1337 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 28, 2025 14:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 28, 2025
@DarkLight1337 DarkLight1337 merged commit 72dfe4c into vllm-project:main Apr 28, 2025
26 of 27 checks passed
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@russellb @DarkLight1337 @dbyoung18
[Docs] Add a security guide (vllm-project#17230)
4d95401 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@russellb @DarkLight1337 @lk-chen
[Docs] Add a security guide (vllm-project#17230)
dd40428 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@russellb @DarkLight1337
[Docs] Add a security guide (vllm-project#17230)
f02b984 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@russellb @DarkLight1337
[Docs] Add a security guide (vllm-project#17230)
df1ca40 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@russellb @mgoin @DarkLight1337